Use new CircleCI convenience image for PHP #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added some todos to the description but this change sounds good! |
|
@becw, even though #176 is merged, Composer grabs the latest release of The Build (which is 4.0-alpha4) during install. That version doesn't have the Devel fix, so palantirnet/drupal-skeleton#119 will fail until there is a new release of 4.x of The Build. [Edited to correct the installed version in the skeleton and clarify that the release doesn't need to be stable.] |
|
@becw, I created https://github.com/palantirnet/the-build/releases/tag/4.0-alpha5 and palantirnet/drupal-skeleton#119 is passing now without specifying the dev branch. |
byrond
commented
Jan 4, 2022
|
@becw I just made one last update to the example deployment config snippets. Otherwise, I think this is ready to go. |
becw
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
Todo:
defaults/install/.circleci/config.ymlMaybe add a comment about when the mysql image will get a cimg version?Update for new MySQL image.developbranch now